NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit3c2313f

committed

Change the pgstat logic so that the stats collector writes the stats file only

upon requests from backends, rather than on a fixed 500msec cycle. (There'sstill throttling logic to ensure it writes no more often than once per500msec, though.) This should result in a significant reduction in stats filewrite traffic in typical scenarios where the stats are demanded onlyinfrequently.This approach also means that the former difficulty with changingstats_temp_directory on-the-fly has gone away, so remove the caution aboutthat as well as the thrashing we did to minimize the trouble window.In passing, also fix pgstat_report_stat() so that we will send a statsmessage if we have function call stats but not table stats to report;this fixes a bug in the recent patch to support function-call stats.Martin Pihlak

1 parentd7112cf commit3c2313fCopy full SHA for 3c2313f

File tree

3 files changed

+204

-65

lines changed

doc/src/sgml
- config.sgml
src
- backend/postmaster
  - pgstat.c
- include
  - pgstat.h

3 files changed

+204

-65

lines changed

`‎doc/src/sgml/config.sgml‎`

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.191 2008/09/30 10:52:09 heikki Exp $ -->`
	`1`	`+<!-- $PostgreSQL: pgsql/doc/src/sgml/config.sgml,v 1.192 2008/11/03 01:17:08 tgl Exp $ -->`
`2`	`2`
`3`	`3`	`<chapter Id="runtime-config">`
`4`	`4`	`<title>Server Configuration</title>`
`@@ -3347,9 +3347,6 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;`
`3347`	`3347`	`improved performance.`
`3348`	`3348`	`This parameter can only be set in the <filename>postgresql.conf</>`
`3349`	`3349`	`file or on the server command line.`
`3350`		`- If this parameter is changed while the server is running, there is a`
`3351`		`- small window of time until the new statistics file has been written`
`3352`		`- during which the statistics functions might return no information.`
`3353`	`3350`	`</para>`
`3354`	`3351`	`</listitem>`
`3355`	`3352`	`</varlistentry>`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3c2313f

File tree

3 files changed

3 files changed

`‎doc/src/sgml/config.sgml‎`

0 commit comments