NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3b8d721

committed

Fix TAP tests for older Perls.

Commit 7132810c (Retain tempdirs for failed tests) used Test::More'sis_passing method, but that was added in Test::More 0.89_01 which issometime later than Perl 5.10.1. Popular platforms such as RHEL6 don'thave that, nevermind some of our older dinosaurs. Do it the hard way.Michael Paquier, based on research by Craig Ringer

1 parenta892234 commit3b8d721Copy full SHA for 3b8d721

File tree

1 file changed

+11

-1

lines changed

src/test/perl
- TestLib.pm

1 file changed

+11

-1

lines changed

`‎src/test/perl/TestLib.pm`

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,17 @@ INIT`
`110`	`110`	`END`
`111`	`111`	`{`
`112`	`112`	`# Preserve temporary directory for this test on failure`
`113`		`-$File::Temp::KEEP_ALL = 1unless Test::More->builder->is_passing;`
	`113`	`+$File::Temp::KEEP_ALL = 1unless all_tests_passing();`
	`114`	`+}`
	`115`	`+`
	`116`	`+suball_tests_passing`
	`117`	`+{`
	`118`	`+my$fail_count = 0;`
	`119`	`+foreachmy$status (Test::More->builder->summary)`
	`120`	`+{`
	`121`	`+return 0unless$status;`
	`122`	`+}`
	`123`	`+return 1;`
`114`	`124`	`}`
`115`	`125`
`116`	`126`	`#`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3b8d721

File tree

1 file changed

1 file changed

`‎src/test/perl/TestLib.pm`

0 commit comments