Commit3b5548a

committed

When using libpq URI syntax, error out on invalid parameter names.

Dan Farina

1 parentf1438cf commit3b5548aCopy full SHA for 3b5548a

File tree

-7

lines changed

-7

lines changed

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -4874,9 +4874,11 @@ conninfo_uri_parse_params(char *params,`
`4874`	`4874`	`return false;`
`4875`	`4875`	`}`
`4876`	`4876`
`4877`		`-fprintf(stderr,`
`4878`		`-libpq_gettext("WARNING: ignoring unrecognized URI query parameter: %s\n"),`
`4879`		`-keyword);`
	`4877`	`+printfPQExpBuffer(errorMessage,`
	`4878`	`+libpq_gettext(`
	`4879`	`+"invalid URI query parameter \"%s\"\n"),`
	`4880`	`+keyword);`
	`4881`	`+return false;`
`4880`	`4882`	`}`
`4881`	`4883`	`if (malloced)`
`4882`	`4884`	`{`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -59,8 +59,8 @@ trying postgresql://host/db?u%73er=someotheruser&port=12345`
`59`	`59`	`user='someotheruser' dbname='db' host='host' port='12345' (inet)`
`60`	`60`
`61`	`61`	`trying postgresql://host/db?u%7aer=someotheruser&port=12345`
`62`		`-WARNING: ignoring unrecognizedURI query parameter:uzer`
`63`		`-dbname='db' host='host' port='12345' (inet)`
	`62`	`+uri-regress: invalidURI query parameter "uzer"`
	`63`	`+`
`64`	`64`
`65`	`65`	`trying postgresql://host:12345?user=uri-user`
`66`	`66`	`user='uri-user' host='host' port='12345' (inet)`
`@@ -102,8 +102,8 @@ trying postgres://?host=/path/to/socket/dir`
`102`	`102`	`host='/path/to/socket/dir' (local)`
`103`	`103`
`104`	`104`	`trying postgresql://host?uzer=`
`105`		`-WARNING: ignoring unrecognizedURI query parameter:uzer`
`106`		`-host='host' (inet)`
	`105`	`+uri-regress: invalidURI query parameter "uzer"`
	`106`	`+`
`107`	`107`
`108`	`108`	`trying postgre://`
`109`	`109`	`uri-regress: missing "=" after "postgre://" in connection info string`

Comments

(0)