NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3a54f4a

committed

Remove ill-conceived Assertion in ProcessClientWriteInterrupt().

It's perfectly fine to have blocked interrupts whenProcessClientWriteInterrupt() is called. In fact it's commonly thecase when emitting error reports. And we deal with that correctly.Even if that'd not be the case, it'd be a bad location for such aassertion. Because ProcessClientWriteInterrupt() is only called whenthe socket is blocked it's hard to hit.Per Heikki and buildfarm animals nightjar and dunlin.

1 parent2505ce0 commit3a54f4aCopy full SHA for 3a54f4a

File tree

1 file changed

-2

lines changed

src/backend/tcop
- postgres.c

1 file changed

-2

lines changed

`‎src/backend/tcop/postgres.c`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -571,8 +571,6 @@ ProcessClientWriteInterrupt(bool blocked)`
`571`	`571`	`{`
`572`	`572`	`intsave_errno=errno;`
`573`	`573`
`574`		`-Assert(InterruptHoldoffCount==0&&CritSectionCount==0);`
`575`		`-`
`576`	`574`	`/*`
`577`	`575`	`* We only want to process the interrupt here if socket writes are`
`578`	`576`	`* blocking to increase the chance to get an error message to the`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3a54f4a

File tree

1 file changed

1 file changed

`‎src/backend/tcop/postgres.c`

0 commit comments