Commit38710a3

committed

Remove unused argument from ginInsertCleanup()

It's an oversight in commitdc943ad.

1 parentc80b31d commit38710a3Copy full SHA for 38710a3

File tree

-10

lines changed

-10

lines changed

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -434,7 +434,7 @@ ginHeapTupleFastInsert(GinState ginstate, GinTupleCollector collector)`
`434`	`434`	`END_CRIT_SECTION();`
`435`	`435`
`436`	`436`	`if (needCleanup)`
`437`		`-ginInsertCleanup(ginstate,false,true,NULL);`
	`437`	`+ginInsertCleanup(ginstate, true,NULL);`
`438`	`438`	`}`
`439`	`439`
`440`	`440`	`/*`
`@@ -732,9 +732,6 @@ processPendingPage(BuildAccumulator accum, KeyArray ka,`
`732`	`732`	`* action of removing a page from the pending list really needs exclusive`
`733`	`733`	`* lock.`
`734`	`734`	`*`
`735`		`- * vac_delay indicates that ginInsertCleanup should call`
`736`		`- * vacuum_delay_point() periodically.`
`737`		`- *`
`738`	`735`	`* fill_fsm indicates that ginInsertCleanup should add deleted pages`
`739`	`736`	`* to FSM otherwise caller is responsible to put deleted pages into`
`740`	`737`	`* FSM.`
`@@ -743,8 +740,7 @@ processPendingPage(BuildAccumulator accum, KeyArray ka,`
`743`	`740`	`*/`
`744`	`741`	`void`
`745`	`742`	`ginInsertCleanup(GinState*ginstate,`
`746`		`-boolvac_delay,boolfill_fsm,`
`747`		`-IndexBulkDeleteResult*stats)`
	`743`	`+boolfill_fsm,IndexBulkDeleteResult*stats)`
`748`	`744`	`{`
`749`	`745`	`Relationindex=ginstate->index;`
`750`	`746`	`Buffermetabuffer,`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -541,7 +541,7 @@ ginbulkdelete(IndexVacuumInfo info, IndexBulkDeleteResult stats,`
`541`	`541`	`/* Yes, so initialize stats to zeroes */`
`542`	`542`	`stats= (IndexBulkDeleteResult*)palloc0(sizeof(IndexBulkDeleteResult));`
`543`	`543`	`/* and cleanup any pending inserts */`
`544`		`-ginInsertCleanup(&gvs.ginstate,true,false,stats);`
	`544`	`+ginInsertCleanup(&gvs.ginstate, false,stats);`
`545`	`545`	`}`
`546`	`546`
`547`	`547`	`/* we'll re-count the tuples each time */`
`@@ -654,7 +654,7 @@ ginvacuumcleanup(IndexVacuumInfo info, IndexBulkDeleteResult stats)`
`654`	`654`	`if (IsAutoVacuumWorkerProcess())`
`655`	`655`	`{`
`656`	`656`	`initGinState(&ginstate,index);`
`657`		`-ginInsertCleanup(&ginstate, true,true,stats);`
	`657`	`+ginInsertCleanup(&ginstate, true,stats);`
`658`	`658`	`}`
`659`	`659`	`returnstats;`
`660`	`660`	`}`
`@@ -667,7 +667,7 @@ ginvacuumcleanup(IndexVacuumInfo info, IndexBulkDeleteResult stats)`
`667`	`667`	`{`
`668`	`668`	`stats= (IndexBulkDeleteResult*)palloc0(sizeof(IndexBulkDeleteResult));`
`669`	`669`	`initGinState(&ginstate,index);`
`670`		`-ginInsertCleanup(&ginstate,true,false,stats);`
	`670`	`+ginInsertCleanup(&ginstate, false,stats);`
`671`	`671`	`}`
`672`	`672`
`673`	`673`	`memset(&idxStat,0,sizeof(idxStat));`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -946,7 +946,7 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,`
`946`	`946`	`OffsetNumberattnum,Datumvalue,boolisNull,`
`947`	`947`	`ItemPointerht_ctid);`
`948`	`948`	`externvoidginInsertCleanup(GinState*ginstate,`
`949`		`-boolvac_delay,boolfill_fsm,IndexBulkDeleteResult*stats);`
	`949`	`+boolfill_fsm,IndexBulkDeleteResult*stats);`
`950`	`950`
`951`	`951`	`/* ginpostinglist.c */`
`952`	`952`

Comments

(0)