Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit37de8de

Browse files
committed
Prevent potentially hazardous compiler/cpu reordering during lwlock release.
In LWLockRelease() (and in 9.4+ LWLockUpdateVar()) we release enqueuedwaiters using PGSemaphoreUnlock(). As there are other sources of suchunlocks backends only wake up if MyProc->lwWaiting is set to false;which is only done in the aforementioned functions.Before this commit there were dangers because the store to lwWaitLinkcould become visible before the store to lwWaitLink. This could bothhappen due to compiler reordering (on most compilers) and on someplatforms due to the CPU reordering stores.The possible consequence of this is that a backend stops waitingbefore lwWaitLink is set to NULL. If that backend then tries toacquire another lock and has to wait there the list could becomecorrupted once the lwWaitLink store is finally performed.Add a write memory barrier to prevent that issue.Unfortunately the barrier support has been only added in 9.2. Giventhat the issue has not knowingly been observed in praxis it seemssufficient to prohibit compiler reordering using volatile for 9.0 and9.1. Actual problems due to compiler reordering are more likelyanyway.Discussion: 20140210134625.GA15246@awork2.anarazel.de
1 parent9959abb commit37de8de

File tree

1 file changed

+14
-0
lines changed

1 file changed

+14
-0
lines changed

‎src/backend/storage/lmgr/lwlock.c

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
#include"miscadmin.h"
3737
#include"pg_trace.h"
3838
#include"replication/slot.h"
39+
#include"storage/barrier.h"
3940
#include"storage/ipc.h"
4041
#include"storage/predicate.h"
4142
#include"storage/proc.h"
@@ -1133,6 +1134,8 @@ LWLockUpdateVar(LWLock *lock, uint64 *valptr, uint64 val)
11331134
proc=head;
11341135
head=proc->lwWaitLink;
11351136
proc->lwWaitLink=NULL;
1137+
/* check comment in LWLockRelease() about this barrier */
1138+
pg_write_barrier();
11361139
proc->lwWaiting= false;
11371140
PGSemaphoreUnlock(&proc->sem);
11381141
}
@@ -1253,6 +1256,17 @@ LWLockRelease(LWLock *lock)
12531256
proc=head;
12541257
head=proc->lwWaitLink;
12551258
proc->lwWaitLink=NULL;
1259+
/*
1260+
* Guarantee that lwWaiting being unset only becomes visible once the
1261+
* unlink from the link has completed. Otherwise the target backend
1262+
* could be woken up for other reason and enqueue for a new lock - if
1263+
* that happens before the list unlink happens, the list would end up
1264+
* being corrupted.
1265+
*
1266+
* The barrier pairs with the SpinLockAcquire() when enqueing for
1267+
* another lock.
1268+
*/
1269+
pg_write_barrier();
12561270
proc->lwWaiting= false;
12571271
PGSemaphoreUnlock(&proc->sem);
12581272
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp