NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3739e5a

committed

Fix pause_at_recovery_target + recovery_target_inclusive combination.

If pause_at_recovery_target is set, recovery pauses *before* applying thetarget record, even if recovery_target_inclusive is set. If you thencontinue with pg_xlog_replay_resume(), it will apply the target recordbefore ending recovery. In other words, if you log in while it's pausedand verify that the database looks OK, ending recovery changes its stateagain, possibly destroying data that you were tring to salvage with PITR.Backpatch to 9.1, this has been broken since pause_at_recovery_target wasadded.

1 parent815d71d commit3739e5aCopy full SHA for 3739e5a

File tree

1 file changed

-5

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-5

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 6 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -6794,11 +6794,6 @@ StartupXLOG(void)`
`6794`	`6794`	`*/`
`6795`	`6795`	`if (recoveryStopsHere(record,&recoveryApply,&recoveryDelay))`
`6796`	`6796`	`{`
`6797`		`-if (recoveryPauseAtTarget)`
`6798`		`-{`
`6799`		`-SetRecoveryPause(true);`
`6800`		`-recoveryPausesHere();`
`6801`		`-}`
`6802`	`6797`	`reachedStopPoint= true;/* see below */`
`6803`	`6798`	`recoveryContinue= false;`
`6804`	`6799`
`@@ -6948,6 +6943,12 @@ StartupXLOG(void)`
`6948`	`6943`	`* end of main redo apply loop`
`6949`	`6944`	`*/`
`6950`	`6945`
	`6946`	`+if (recoveryPauseAtTarget&&reachedStopPoint)`
	`6947`	`+{`
	`6948`	`+SetRecoveryPause(true);`
	`6949`	`+recoveryPausesHere();`
	`6950`	`+}`
	`6951`	`+`
`6951`	`6952`	`ereport(LOG,`
`6952`	`6953`	`(errmsg("redo done at %X/%X",`
`6953`	`6954`	`(uint32) (ReadRecPtr >>32), (uint32)ReadRecPtr)));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3739e5a

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments