NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit370a46f

committed

Add new snapshot fields to serialize/deserialize functions.

The "snapshot too old" condition was not being recognized whenusing a copied snapshot, since the original timestamp and lsn werenot being passed along. Noticed when testing the combination of"snapshot too old" with parallel query execution.

1 parent6436a85 commit370a46fCopy full SHA for 370a46f

File tree

1 file changed

-0

lines changed

src/backend/utils/time
- snapmgr.c

1 file changed

-0

lines changed

`‎src/backend/utils/time/snapmgr.c‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -239,6 +239,8 @@ typedef struct SerializedSnapshotData`
`239`	`239`	`boolsuboverflowed;`
`240`	`240`	`booltakenDuringRecovery;`
`241`	`241`	`CommandIdcurcid;`
	`242`	`+int64whenTaken;`
	`243`	`+XLogRecPtrlsn;`
`242`	`244`	`}SerializedSnapshotData;`
`243`	`245`
`244`	`246`	`Size`
`@@ -1936,6 +1938,8 @@ SerializeSnapshot(Snapshot snapshot, char *start_address)`
`1936`	`1938`	`serialized_snapshot->suboverflowed=snapshot->suboverflowed;`
`1937`	`1939`	`serialized_snapshot->takenDuringRecovery=snapshot->takenDuringRecovery;`
`1938`	`1940`	`serialized_snapshot->curcid=snapshot->curcid;`
	`1941`	`+serialized_snapshot->whenTaken=snapshot->whenTaken;`
	`1942`	`+serialized_snapshot->lsn=snapshot->lsn;`
`1939`	`1943`
`1940`	`1944`	`/*`
`1941`	`1945`	`* Ignore the SubXID array if it has overflowed, unless the snapshot was`
`@@ -2002,6 +2006,8 @@ RestoreSnapshot(char *start_address)`
`2002`	`2006`	`snapshot->suboverflowed=serialized_snapshot->suboverflowed;`
`2003`	`2007`	`snapshot->takenDuringRecovery=serialized_snapshot->takenDuringRecovery;`
`2004`	`2008`	`snapshot->curcid=serialized_snapshot->curcid;`
	`2009`	`+snapshot->whenTaken=serialized_snapshot->whenTaken;`
	`2010`	`+snapshot->lsn=serialized_snapshot->lsn;`
`2005`	`2011`
`2006`	`2012`	`/* Copy XIDs, if present. */`
`2007`	`2013`	`if (serialized_snapshot->xcnt>0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit370a46f

File tree

1 file changed

1 file changed

`‎src/backend/utils/time/snapmgr.c‎`

0 commit comments