NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit360ca27

committed

Remove mergeHyperLogLog.

It's buggy. If somebody needs this later, they'll need to put backa non-buggy vesion of it.Discussion: CAM3SWZT-i6R9JU5YXa8MJUou2_r3LfGJZpQ9tYa1BYxfkj0=cQ@mail.gmail.comDiscussion: CAM3SWZRUOLsYoTT83QgdUy9D8ehYWm_nvbrrfcOOzikiRfFY7g@mail.gmail.comPeter Geoghegan

1 parent59eb551 commit360ca27Copy full SHA for 360ca27

File tree

2 files changed

-23

lines changed

src
- backend/lib
  - hyperloglog.c
- include/lib
  - hyperloglog.h

2 files changed

-23

lines changed

`‎src/backend/lib/hyperloglog.c`

Lines changed: 0 additions & 22 deletions

Original file line number	Diff line number	Diff line change
`@@ -220,28 +220,6 @@ estimateHyperLogLog(hyperLogLogState *cState)`
`220`	`220`	`returnresult;`
`221`	`221`	`}`
`222`	`222`
`223`		`-/*`
`224`		`- * Merges the estimate from one HyperLogLog state to another, returning the`
`225`		`- * estimate of their union.`
`226`		`- *`
`227`		`- * The number of registers in each must match.`
`228`		`- */`
`229`		`-void`
`230`		`-mergeHyperLogLog(hyperLogLogStatecState,consthyperLogLogStateoState)`
`231`		`-{`
`232`		`-intr;`
`233`		`-`
`234`		`-if (cState->nRegisters!=oState->nRegisters)`
`235`		`-elog(ERROR,"number of registers mismatch: %zu != %zu",`
`236`		`-cState->nRegisters,oState->nRegisters);`
`237`		`-`
`238`		`-for (r=0;r<cState->nRegisters;++r)`
`239`		`-{`
`240`		`-cState->hashesArr[r]=Max(cState->hashesArr[r],oState->hashesArr[r]);`
`241`		`-}`
`242`		`-}`
`243`		`-`
`244`		`-`
`245`	`223`	`/*`
`246`	`224`	`* Worker for addHyperLogLog().`
`247`	`225`	`*`

`‎src/include/lib/hyperloglog.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,6 @@ extern void initHyperLogLog(hyperLogLogState *cState, uint8 bwidth);`
`63`	`63`	`externvoidinitHyperLogLogError(hyperLogLogState*cState,doubleerror);`
`64`	`64`	`externvoidaddHyperLogLog(hyperLogLogState*cState,uint32hash);`
`65`	`65`	`externdoubleestimateHyperLogLog(hyperLogLogState*cState);`
`66`		`-externvoidmergeHyperLogLog(hyperLogLogStatecState,consthyperLogLogStateoState);`
`67`	`66`	`externvoidfreeHyperLogLog(hyperLogLogState*cState);`
`68`	`67`
`69`	`68`	`#endif/* HYPERLOGLOG_H */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit360ca27

File tree

2 files changed

2 files changed

`‎src/backend/lib/hyperloglog.c`

`‎src/include/lib/hyperloglog.h`

0 commit comments