Commit357edc9

committed

Adjust comments about what's needed to avoid make 3.80 bug.

... based on further tracing through that code.

1 parent5ccbc3d commit357edc9Copy full SHA for 357edc9

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -559,9 +559,10 @@ endif`
`559`	`559`	`# This function is only for internal use below. It should be called`
`560`	`560`	`# using $(eval). It will set up a target so that it recurses into`
`561`	`561`	`# a given subdirectory. Note that to avoid a nasty bug in make 3.80,`
`562`		`-# it is important that the expansion of this function not exceed about`
`563`		`-# 200 bytes. This is why we make it apply to just one subdirectory at a`
`564`		`-# time, rather than to a list of subdirectories.`
	`562`	`+# this function has to avoid using any complicated constructs (like`
	`563`	`+# multiple targets on a line) and also not contain any lines that expand`
	`564`	`+# to more than about 200 bytes. This is why we make it apply to just one`
	`565`	`+# subdirectory at a time, rather than to a list of subdirectories.`
`565`	`566`	`# $1: target name, e.g., all`
`566`	`567`	`# $2: subdir name`
`567`	`568`	`# $3: target to run in subdir, usually same as $1`

Comments

(0)