NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit346199d

committed

Set the priorities of all quorum synchronous standbys to 1.

In quorum-based synchronous replication, all the standbys listed insynchronous_standby_names equally have chances to be chosenas synchronous standbys. So they should have the same priority.However, previously, quorum standbys whose names appear earlierin the list were given higher priority values though the difference ofthose priority values didn't affect the selection of synchronous standbys.Users could see those "meaningless" priority values in pg_stat_replicationand this was confusing.This commit gives all the quorum synchronous standbys the samehighest priority, i.e., 1, in order to remove such confusion.Author: Fujii MasaoReviewed-by: Masahiko Sawada, Kyotaro HoriguchiDiscussion:http://postgr.es/m/CAHGQGwEKOw=SmPLxJzkBsH6wwDBgOnVz46QjHbtsiZ-d-2RGUg@mail.gmail.com

1 parentcdd5bca commit346199dCopy full SHA for 346199d

File tree

2 files changed

-2

lines changed

src
- backend/replication
  - syncrep.c
- test/recovery/t
  - 007_sync_rep.pl

2 files changed

-2

lines changed

`‎src/backend/replication/syncrep.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -951,7 +951,14 @@ SyncRepGetStandbyPriority(void)`
`951`	`951`	`standby_name+=strlen(standby_name)+1;`
`952`	`952`	`}`
`953`	`953`
`954`		`-return (found ?priority :0);`
	`954`	`+if (!found)`
	`955`	`+return0;`
	`956`	`+`
	`957`	`+/*`
	`958`	`+ * In quorum-based sync replication, all the standbys in the list`
	`959`	`+ * have the same priority, one.`
	`960`	`+ */`
	`961`	`+return (SyncRepConfig->syncrep_method==SYNC_REP_PRIORITY) ?priority :1;`
`955`	`962`	`}`
`956`	`963`
`957`	`964`	`/*`

`‎src/test/recovery/t/007_sync_rep.pl`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ sub test_sync_state`
`186`	`186`	`# for sync standbys in a quorum-based sync replication.`
`187`	`187`	`test_sync_state(`
`188`	`188`	`$node_master,qq(standby1\|1\|quorum`
`189`		`-standby2\|2\|quorum`
	`189`	`+standby2\|1\|quorum`
`190`	`190`	`standby4\|0\|async),`
`191`	`191`	`'2 quorum and 1 async',`
`192`	`192`	`'ANY 2(standby1, standby2)');`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit346199d

File tree

2 files changed

2 files changed

`‎src/backend/replication/syncrep.c`

`‎src/test/recovery/t/007_sync_rep.pl`

0 commit comments