NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit343bb13

committed

Avoid too-large shift on 32-bit Windows.

Apparently, shifts greater than or equal to the width of the typeare undefined, and can surprisingly produce a non-zero value.Amit Kapila, with a comment by me.

1 parent6756c8a commit343bb13Copy full SHA for 343bb13

File tree

1 file changed

+11

-2

lines changed

src/backend/storage/ipc
- dsm_impl.c

1 file changed

+11

-2

lines changed

`‎src/backend/storage/ipc/dsm_impl.c`

Lines changed: 11 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -673,8 +673,17 @@ dsm_impl_windows(dsm_op op, dsm_handle handle, Size request_size,`
`673`	`673`	`/* Create new segment or open an existing one for attach. */`
`674`	`674`	`if (op==DSM_OP_CREATE)`
`675`	`675`	`{`
`676`		`-DWORDsize_high= (DWORD) (request_size >>32);`
`677`		`-DWORDsize_low= (DWORD)request_size;`
	`676`	`+DWORDsize_high;`
	`677`	`+DWORDsize_low;`
	`678`	`+`
	`679`	`+/* Shifts >= the width of the type are undefined. */`
	`680`	`+#ifdef_WIN64`
	`681`	`+size_high=request_size >>32;`
	`682`	`+#else`
	`683`	`+size_high=0;`
	`684`	`+#endif`
	`685`	`+size_low= (DWORD)request_size;`
	`686`	`+`
`678`	`687`	`hmap=CreateFileMapping(INVALID_HANDLE_VALUE,/* Use the pagefile */`
`679`	`688`	`NULL,/* Default security attrs */`
`680`	`689`	`PAGE_READWRITE,/* Memory is read/write */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit343bb13

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/dsm_impl.c`

0 commit comments