NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3355443

committed

Check version before allocating PQExpBuffer

In pg_dump.c:getEventTriggers, check what major version we are onbefore calling createPQExpBuffer() to avoid leaking that bit ofmemory.Leak discovered by the Coverity scanner.Back-patch to 9.3 where support for dumping event triggers wasadded.

1 parent01337d4 commit3355443Copy full SHA for 3355443

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5746,7 +5746,7 @@ EventTriggerInfo *`
`5746`	`5746`	`getEventTriggers(Archivefout,intnumEventTriggers)`
`5747`	`5747`	`{`
`5748`	`5748`	`inti;`
`5749`		`-PQExpBufferquery=createPQExpBuffer();`
	`5749`	`+PQExpBufferquery;`
`5750`	`5750`	`PGresult*res;`
`5751`	`5751`	`EventTriggerInfo*evtinfo;`
`5752`	`5752`	`inti_tableoid,`
`@@ -5766,6 +5766,8 @@ getEventTriggers(Archive fout, int numEventTriggers)`
`5766`	`5766`	`returnNULL;`
`5767`	`5767`	`}`
`5768`	`5768`
	`5769`	`+query=createPQExpBuffer();`
	`5770`	`+`
`5769`	`5771`	`/* Make sure we are in proper schema */`
`5770`	`5772`	`selectSourceSchema(fout,"pg_catalog");`
`5771`	`5773`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3355443

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments