Commit331bf67

committed

Throw error sooner for unlogged GiST indexes.

Throwing an error only after we've built the main index fork is prettyunfriendly when the table already contains data. Per gripe from JayLevitt.

1 parentd77354e commit331bf67Copy full SHA for 331bf67

File tree

+10

-0

lines changed

+10

-0

lines changed

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,16 @@ gistbuild(PG_FUNCTION_ARGS)`
`144`	`144`	`elog(ERROR,"index \"%s\" already contains data",`
`145`	`145`	`RelationGetRelationName(index));`
`146`	`146`
	`147`	`+/*`
	`148`	`+ * We can't yet handle unlogged GiST indexes, because we depend on LSNs.`
	`149`	`+ * This is duplicative of an error in gistbuildempty, but we want to check`
	`150`	`+ * here so as to throw error before doing all the index-build work.`
	`151`	`+ */`
	`152`	`+if (heap->rd_rel->relpersistence==RELPERSISTENCE_UNLOGGED)`
	`153`	`+ereport(ERROR,`
	`154`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`155`	`+errmsg("unlogged GiST indexes are not supported")));`
	`156`	`+`
`147`	`157`	`/* no locking is needed */`
`148`	`158`	`buildstate.giststate=initGISTstate(index);`
`149`	`159`

Comments

(0)