NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3154e16

committed

Dodge compiler bug in Visual Studio 2013.

VS2013 apparently has a problem with taking the address of a formalparameter in some cases. We do that elsewhere without trouble, butin this case the address is being passed to a subroutine that willprobably get inlined, so maybe the combination of those things iswhat tickles the bug. Anyway, introducing an extra copy of theparameter value is enough to work around it. Per trouble reportfrom Umair Shahid.Report: <CAM184AcjqKYZSdQqBHDrnENXHhW=mXbUC46QYPJ=nAh0gUHCGA@mail.gmail.com>

1 parent8ebb69f commit3154e16Copy full SHA for 3154e16

File tree

1 file changed

-1

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3914,8 +3914,10 @@ calc_joinrel_size_estimate(PlannerInfo *root,`
`3914`	`3914`	`doubleouter_rows,`
`3915`	`3915`	`doubleinner_rows,`
`3916`	`3916`	`SpecialJoinInfo*sjinfo,`
`3917`		`-List*restrictlist)`
	`3917`	`+List*restrictlist_in)`
`3918`	`3918`	`{`
	`3919`	`+/* This apparently-useless variable dodges a compiler bug in VS2013: */`
	`3920`	`+List*restrictlist=restrictlist_in;`
`3919`	`3921`	`JoinTypejointype=sjinfo->jointype;`
`3920`	`3922`	`Selectivityfkselec;`
`3921`	`3923`	`Selectivityjselec;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3154e16

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments