Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit309c647

Browse files
committed
Rename track_iotiming GUC to track_io_timing.
This spelling seems significantly more readable to me.
1 parent5f2b089 commit309c647

File tree

7 files changed

+18
-17
lines changed

7 files changed

+18
-17
lines changed

‎doc/src/sgml/config.sgml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4288,18 +4288,19 @@ COPY postgres_log FROM '/full/path/to/logfile.csv' WITH csv;
42884288
</listitem>
42894289
</varlistentry>
42904290

4291-
<varlistentry id="guc-track-iotiming" xreflabel="track_iotiming">
4292-
<term><varname>track_iotiming</varname> (<type>boolean</type>)</term>
4291+
<varlistentry id="guc-track-io-timing" xreflabel="track_io_timing">
4292+
<term><varname>track_io_timing</varname> (<type>boolean</type>)</term>
42934293
<indexterm>
4294-
<primary><varname>track_iotiming</> configuration parameter</primary>
4294+
<primary><varname>track_io_timing</> configuration parameter</primary>
42954295
</indexterm>
42964296
<listitem>
42974297
<para>
42984298
Enables timing of database I/O calls. This parameter is off by
42994299
default, because it will repeatedly query the operating system for
43004300
the current time, which may cause significant overhead on some
43014301
platforms. You can use the <xref linkend="pgtesttiming"> tool to
4302-
measure the overhead of timing on your system. Timing information is
4302+
measure the overhead of timing on your system.
4303+
I/O timing information is
43034304
displayed in <xref linkend="pg-stat-database-view">, in the output of
43044305
<xref linkend="sql-explain"> when the <literal>BUFFERS</> option is
43054306
used, and by <xref linkend="pgstatstatements">. Only superusers can

‎doc/src/sgml/monitoring.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ postgres: <replaceable>user</> <replaceable>database</> <replaceable>host</> <re
155155
</para>
156156

157157
<para>
158-
The parameter <xref linkend="guc-track-iotiming"> enables monitoring
158+
The parameter <xref linkend="guc-track-io-timing"> enables monitoring
159159
of block read and write times.
160160
</para>
161161

‎doc/src/sgml/pgstatstatements.sgml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@
161161
<entry></entry>
162162
<entry>
163163
Total time the statement spent reading blocks, in milliseconds
164-
(if <xref linkend="guc-track-iotiming"> is enabled, otherwise zero)
164+
(if <xref linkend="guc-track-io-timing"> is enabled, otherwise zero)
165165
</entry>
166166
</row>
167167

@@ -171,7 +171,7 @@
171171
<entry></entry>
172172
<entry>
173173
Total time the statement spent writing blocks, in milliseconds
174-
(if <xref linkend="guc-track-iotiming"> is enabled, otherwise zero)
174+
(if <xref linkend="guc-track-io-timing"> is enabled, otherwise zero)
175175
</entry>
176176
</row>
177177

‎src/backend/storage/buffer/bufmgr.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
boolzero_damaged_pages= false;
6868
intbgwriter_lru_maxpages=100;
6969
doublebgwriter_lru_multiplier=2.0;
70-
booltrack_iotiming= false;
70+
booltrack_io_timing= false;
7171

7272
/*
7373
* How many buffers PrefetchBuffer callers should try to stay ahead of their
@@ -441,12 +441,12 @@ ReadBuffer_common(SMgrRelation smgr, char relpersistence, ForkNumber forkNum,
441441
instr_timeio_start,
442442
io_time;
443443

444-
if (track_iotiming)
444+
if (track_io_timing)
445445
INSTR_TIME_SET_CURRENT(io_start);
446446

447447
smgrread(smgr,forkNum,blockNum, (char*)bufBlock);
448448

449-
if (track_iotiming)
449+
if (track_io_timing)
450450
{
451451
INSTR_TIME_SET_CURRENT(io_time);
452452
INSTR_TIME_SUBTRACT(io_time,io_start);
@@ -1938,7 +1938,7 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
19381938
buf->flags &= ~BM_JUST_DIRTIED;
19391939
UnlockBufHdr(buf);
19401940

1941-
if (track_iotiming)
1941+
if (track_io_timing)
19421942
INSTR_TIME_SET_CURRENT(io_start);
19431943

19441944
smgrwrite(reln,
@@ -1947,7 +1947,7 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
19471947
(char*)BufHdrGetBlock(buf),
19481948
false);
19491949

1950-
if (track_iotiming)
1950+
if (track_io_timing)
19511951
{
19521952
INSTR_TIME_SET_CURRENT(io_time);
19531953
INSTR_TIME_SUBTRACT(io_time,io_start);

‎src/backend/utils/misc/guc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,11 +1019,11 @@ static struct config_bool ConfigureNamesBool[] =
10191019
NULL,NULL,NULL
10201020
},
10211021
{
1022-
{"track_iotiming",PGC_SUSET,STATS_COLLECTOR,
1023-
gettext_noop("Collects timinginformation for databaseIO activity."),
1022+
{"track_io_timing",PGC_SUSET,STATS_COLLECTOR,
1023+
gettext_noop("Collects timingstatistics for databaseI/O activity."),
10241024
NULL
10251025
},
1026-
&track_iotiming,
1026+
&track_io_timing,
10271027
false,
10281028
NULL,NULL,NULL
10291029
},

‎src/backend/utils/misc/postgresql.conf.sample

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@
425425

426426
#track_activities = on
427427
#track_counts = on
428-
#track_iotiming = off
428+
#track_io_timing = off
429429
#track_functions = none# none, pl, all
430430
#track_activity_query_size = 1024 # (change requires restart)
431431
#update_process_title = on

‎src/include/storage/bufmgr.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ extern PGDLLIMPORT int NBuffers;
4848
externboolzero_damaged_pages;
4949
externintbgwriter_lru_maxpages;
5050
externdoublebgwriter_lru_multiplier;
51-
externbooltrack_iotiming;
51+
externbooltrack_io_timing;
5252
externinttarget_prefetch_pages;
5353

5454
/* in buf_init.c */

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp