NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit3049fe7

committed

Make the bgwriter's error recovery path do smgrcloseall(). On Windows this

should allow delete-pending files to actually go away, and thereby workaround the various complaints we've seen about 'permission denied'errors in such cases. Should be reasonably harmless in any case...

1 parentb02414b commit3049fe7Copy full SHA for 3049fe7

File tree

1 file changed

-1

lines changed

src/backend/postmaster
- bgwriter.c

1 file changed

-1

lines changed

`‎src/backend/postmaster/bgwriter.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.32 2006/11/30 18:29:12 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.33 2006/12/01 19:55:28 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -304,6 +304,13 @@ BackgroundWriterMain(void)`
`304`	`304`	`* fast as we can.`
`305`	`305`	`*/`
`306`	`306`	`pg_usleep(1000000L);`
	`307`	`+`
	`308`	`+/*`
	`309`	`+ * Close all open files after any error. This is helpful on Windows,`
	`310`	`+ * where holding deleted files open causes various strange errors.`
	`311`	`+ * It's not clear we need it elsewhere, but shouldn't hurt.`
	`312`	`+ */`
	`313`	`+smgrcloseall();`
`307`	`314`	`}`
`308`	`315`
`309`	`316`	`/* We can now handle ereport(ERROR) */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3049fe7

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/bgwriter.c`

0 commit comments