Commit301ca0d

committed

Fix AclResult vs bool type mix-up

Using AclResult as a bool or vice versa works by accident, but it'sunusual and possibly confusing style, so write it out more explicitly.

1 parentb1fc51a commit301ca0dCopy full SHA for 301ca0d

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,9 @@ pgrowlocks(PG_FUNCTION_ARGS)`
`101`	`101`
`102`	`102`	`/* check permissions: must have SELECT on table or be in pg_stat_scan_tables */`
`103`	`103`	`aclresult=pg_class_aclcheck(RelationGetRelid(rel),GetUserId(),`
`104`		`-ACL_SELECT)\|\|`
`105`		`-is_member_of_role(GetUserId(),DEFAULT_ROLE_STAT_SCAN_TABLES);`
	`104`	`+ACL_SELECT);`
	`105`	`+if (aclresult!=ACLCHECK_OK)`
	`106`	`+aclresult=is_member_of_role(GetUserId(),DEFAULT_ROLE_STAT_SCAN_TABLES) ?ACLCHECK_OK :ACLCHECK_NO_PRIV;`
`106`	`107`
`107`	`108`	`if (aclresult!=ACLCHECK_OK)`
`108`	`109`	`aclcheck_error(aclresult,ACL_KIND_CLASS,`

Comments

(0)