NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2ef6c66

committed

Fix file descriptor leak at end of recovery.

XLogFileInit() returns a file descriptor, which needs to be closed. The leakwas short-lived, since the startup process exits shortly afterwards, but itwas clearly a bug, nevertheless.Per Coverity report.

1 parentcfb64fd commit2ef6c66Copy full SHA for 2ef6c66

File tree

1 file changed

-1

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-1

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5043,8 +5043,15 @@ exitArchiveRecovery(TimeLineID endTLI, XLogRecPtr endOfLog)`
`5043`	`5043`	`else`
`5044`	`5044`	`{`
`5045`	`5045`	`booluse_existent= true;`
	`5046`	`+intfd;`
`5046`	`5047`
`5047`		`-XLogFileInit(startLogSegNo,&use_existent, true);`
	`5048`	`+fd=XLogFileInit(startLogSegNo,&use_existent, true);`
	`5049`	`+`
	`5050`	`+if (close(fd))`
	`5051`	`+ereport(ERROR,`
	`5052`	`+(errcode_for_file_access(),`
	`5053`	`+errmsg("could not close log file %s: %m",`
	`5054`	`+XLogFileNameP(ThisTimeLineID,startLogSegNo))));`
`5048`	`5055`	`}`
`5049`	`5056`
`5050`	`5057`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2ef6c66

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments