NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2e852e5

committed

Remove ExecRemoveJunk(), which is no longer used anywhere.

This was a leftover from the pre-8.1 design of junkfilters. It doesn'tseem to have any reason to live, since it's merely a combination of twoeasy function calls, and not a well-designed combination at that (itencourages callers to leak the result tuple).

1 parenta210be7 commit2e852e5Copy full SHA for 2e852e5

File tree

2 files changed

-16

lines changed

src
- backend/executor
  - execJunk.c
- include/executor
  - executor.h

2 files changed

-16

lines changed

`‎src/backend/executor/execJunk.c`

Lines changed: 3 additions & 15 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,9 +40,9 @@`
`40`	`40`	`*`
`41`	`41`	`* Finally, when at the top level we get back a tuple, we can call`
`42`	`42`	`* ExecFindJunkAttribute/ExecGetJunkAttribute to retrieve the values of the`
`43`		`- * junk attributes we are interested in, and ExecFilterJunkor ExecRemoveJunk`
`44`		`- *to remove all thejunk attributes from a tuple. This new "clean" tuple is`
`45`		`- *then printed,inserted, or updated.`
	`43`	`+ * junk attributes we are interested in, and ExecFilterJunkto remove all the`
	`44`	`+ * junk attributes from a tuple.This new "clean" tuple is then printed,`
	`45`	`+ * inserted, or updated.`
`46`	`46`	`*`
`47`	`47`	`*-------------------------------------------------------------------------`
`48`	`48`	`*/`
`@@ -317,15 +317,3 @@ ExecFilterJunk(JunkFilter junkfilter, TupleTableSlot slot)`
`317`	`317`	`*/`
`318`	`318`	`returnExecStoreVirtualTuple(resultSlot);`
`319`	`319`	`}`
`320`		`-`
`321`		`-/*`
`322`		`- * ExecRemoveJunk`
`323`		`- *`
`324`		`- * Convenience routine to generate a physical clean tuple,`
`325`		`- * rather than just a virtual slot.`
`326`		`- */`
`327`		`-HeapTuple`
`328`		`-ExecRemoveJunk(JunkFilterjunkfilter,TupleTableSlotslot)`
`329`		`-{`
`330`		`-returnExecCopySlotTuple(ExecFilterJunk(junkfilter,slot));`
`331`		`-}`

`‎src/include/executor/executor.h`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,6 @@ extern Datum ExecGetJunkAttribute(TupleTableSlot *slot, AttrNumber attno,`
`148`	`148`	`bool*isNull);`
`149`	`149`	`externTupleTableSlotExecFilterJunk(JunkFilterjunkfilter,`
`150`	`150`	`TupleTableSlot*slot);`
`151`		`-externHeapTupleExecRemoveJunk(JunkFilterjunkfilter,TupleTableSlotslot);`
`152`	`151`
`153`	`152`
`154`	`153`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2e852e5

File tree

2 files changed

2 files changed

`‎src/backend/executor/execJunk.c`

`‎src/include/executor/executor.h`

0 commit comments