NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2de48a8

committed

Cleanup and code review for the patch that made bgwriter active during

archive recovery. Invent a separate state variable and inquiry functionfor XLogInsertAllowed() to clarify some tests and make the management ofwriting the end-of-recovery checkpoint less klugy. Fix several placesthat were incorrectly testing InRecovery when they should be looking atRecoveryInProgress or XLogInsertAllowed (because they will now be executedin the bgwriter not startup process). Clarify handling of bad LSNs passedto XLogFlush during recovery. Use a spinlock for setting/testingSharedRecoveryInProgress. Improve quite a lot of comments.Heikki and Tom

1 parenta6667d9 commit2de48a8Copy full SHA for 2de48a8

File tree

6 files changed

+244

-131

lines changed

src
- backend
  - access/transam
    - multixact.c
    - xlog.c
  - postmaster
    - bgwriter.c
    - postmaster.c
  - storage/smgr
    - md.c
- include/access
  - xlog.h

6 files changed

+244

-131

lines changed

`‎src/backend/access/transam/multixact.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@`
`42`	`42`	`* Portions Copyright (c) 1996-2009, PostgreSQL Global Development Group`
`43`	`43`	`* Portions Copyright (c) 1994, Regents of the University of California`
`44`	`44`	`*`
`45`		`- * $PostgreSQL: pgsql/src/backend/access/transam/multixact.c,v 1.30 2009/01/20 18:59:37 heikki Exp $`
	`45`	`+ * $PostgreSQL: pgsql/src/backend/access/transam/multixact.c,v 1.31 2009/06/26 20:29:04 tgl Exp $`
`46`	`46`	`*`
`47`	`47`	`*-------------------------------------------------------------------------`
`48`	`48`	`*/`
`@@ -1543,7 +1543,7 @@ CheckPointMultiXact(void)`
`1543`	`1543`	`* SimpleLruTruncate would get confused. It seems best not to risk`
`1544`	`1544`	`* removing any data during recovery anyway, so don't truncate.`
`1545`	`1545`	`*/`
`1546`		`-if (!InRecovery)`
	`1546`	`+if (!RecoveryInProgress())`
`1547`	`1547`	`TruncateMultiXact();`
`1548`	`1548`
`1549`	`1549`	`TRACE_POSTGRESQL_MULTIXACT_CHECKPOINT_DONE(true);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2de48a8

File tree

6 files changed

6 files changed

`‎src/backend/access/transam/multixact.c`

0 commit comments