NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2af72ce

committed

Add missing Assert and fix inaccurate elog message in standby_redo().

All other WAL redo routines either call RestoreBkpBlocks() or Assert thatthey haven't been passed any backup blocks. Make this one do likewise.Also, fix incorrect routine name in its failure message.

1 parent9bff078 commit2af72ceCopy full SHA for 2af72ce

File tree

1 file changed

-1

lines changed

src/backend/storage/ipc
- standby.c

1 file changed

-1

lines changed

`‎src/backend/storage/ipc/standby.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -718,6 +718,9 @@ standby_redo(XLogRecPtr lsn, XLogRecord *record)`
`718`	`718`	`{`
`719`	`719`	`uint8info=record->xl_info& ~XLR_INFO_MASK;`
`720`	`720`
	`721`	`+/* Backup blocks are not used in standby records */`
	`722`	`+Assert(!(record->xl_info&XLR_BKP_BLOCK_MASK));`
	`723`	`+`
`721`	`724`	`/* Do nothing if we're not in hot standby mode */`
`722`	`725`	`if (standbyState==STANDBY_DISABLED)`
`723`	`726`	`return;`
`@@ -747,7 +750,7 @@ standby_redo(XLogRecPtr lsn, XLogRecord *record)`
`747`	`750`	`ProcArrayApplyRecoveryInfo(&running);`
`748`	`751`	`}`
`749`	`752`	`else`
`750`		`-elog(PANIC,"relation_redo: unknown op code %u",info);`
	`753`	`+elog(PANIC,"standby_redo: unknown op code %u",info);`
`751`	`754`	`}`
`752`	`755`
`753`	`756`	`staticvoid`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2af72ce

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/standby.c`

0 commit comments