NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2a781d5

committed

Acquire appropriate locks when rewriting during RMV.

Since the query has not been freshly parsed when executing REFRESHMATERIALIZED VIEW, locks must be explicitly taken before rewrite.Backpatch to 9.3.Andres Freund

1 parentbe420fa commit2a781d5Copy full SHA for 2a781d5

File tree

1 file changed

-2

lines changed

src/backend/commands
- matview.c

1 file changed

-2

lines changed

`‎src/backend/commands/matview.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,7 @@ refresh_matview_datafill(DestReceiver dest, Query query,`
`283`	`283`	`Oidsave_userid;`
`284`	`284`	`intsave_sec_context;`
`285`	`285`	`intsave_nestlevel;`
	`286`	`+Query*copied_query;`
`286`	`287`
`287`	`288`	`/*`
`288`	`289`	`* Switch to the owner's userid, so that any functions are run as that`
`@@ -294,8 +295,10 @@ refresh_matview_datafill(DestReceiver dest, Query query,`
`294`	`295`	`save_sec_context \|SECURITY_RESTRICTED_OPERATION);`
`295`	`296`	`save_nestlevel=NewGUCNestLevel();`
`296`	`297`
`297`		`-/* Rewrite, copying the given Query to make sure it's not changed */`
`298`		`-rewritten=QueryRewrite((Query*)copyObject(query));`
	`298`	`+/* Lock and rewrite, using a copy to preserve the original query. */`
	`299`	`+copied_query=copyObject(query);`
	`300`	`+AcquireRewriteLocks(copied_query, false);`
	`301`	`+rewritten=QueryRewrite(copied_query);`
`299`	`302`
`300`	`303`	`/* SELECT should never rewrite to more or less than one SELECT query */`
`301`	`304`	`if (list_length(rewritten)!=1)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2a781d5

File tree

1 file changed

1 file changed

`‎src/backend/commands/matview.c`

0 commit comments