NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit294c34b

committed

Fix rounding problem in dynahash.c's decision about when the target

fill factor has been exceeded. We usually run with ffactor == 1, butthe way the test was coded, it wouldn't split a bucket until the actualfill factor reached 2.0, because of use of integer division. Changefrom > to >= so that it will split more aggressively when the tablestarts to get full.

1 parent7f1711f commit294c34bCopy full SHA for 294c34b

File tree

1 file changed

-2

lines changed

src/backend/utils/hash
- dynahash.c

1 file changed

-2

lines changed

`‎src/backend/utils/hash/dynahash.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.56 2004/10/25 00:46:43 neilc Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.57 2004/11/21 22:57:00 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -662,7 +662,7 @@ hash_search(HTAB *hashp,`
`662`	`662`	`/* caller is expected to fill the data field on return */`
`663`	`663`
`664`	`664`	`/* Check if it is time to split the segment */`
`665`		`-if (++hctl->nentries / (long) (hctl->max_bucket+1)>hctl->ffactor)`
	`665`	`+if (++hctl->nentries / (long) (hctl->max_bucket+1) >=hctl->ffactor)`
`666`	`666`	`{`
`667`	`667`	`/*`
`668`	`668`	`* NOTE: failure to expand table is not a fatal error, it`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit294c34b

File tree

1 file changed

1 file changed

`‎src/backend/utils/hash/dynahash.c`

0 commit comments