NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit290713e

committed

Fix another test for RELKIND_RELATION that should allow foreign tables now.

I thought I'd gone through all of these before, but a fresh review foundthis one too. (Perhaps it would be better to just delete this test andlet the failure occur later, but for the moment I'll preserve the logic.)The case that this was rejecting is likeCREATE FOREIGN TABLE ft (f1 int ...) ...;CREATE TABLE c1 (UNIQUE(f1)) INHERITS(ft);

1 parentad9f08f commit290713eCopy full SHA for 290713e

File tree

1 file changed

-2

lines changed

src/backend/parser
- parse_utilcmd.c

1 file changed

-2

lines changed

`‎src/backend/parser/parse_utilcmd.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1799,10 +1799,12 @@ transformIndexConstraint(Constraint constraint, CreateStmtContext cxt)`
`1799`	`1799`
`1800`	`1800`	`Assert(IsA(inh,RangeVar));`
`1801`	`1801`	`rel=heap_openrv(inh,AccessShareLock);`
`1802`		`-if (rel->rd_rel->relkind!=RELKIND_RELATION)`
	`1802`	`+/* check user requested inheritance from valid relkind */`
	`1803`	`+if (rel->rd_rel->relkind!=RELKIND_RELATION&&`
	`1804`	`+rel->rd_rel->relkind!=RELKIND_FOREIGN_TABLE)`
`1803`	`1805`	`ereport(ERROR,`
`1804`	`1806`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`1805`		`-errmsg("inherited relation \"%s\" is not a table",`
	`1807`	`+errmsg("inherited relation \"%s\" is not a table or foreign table",`
`1806`	`1808`	`inh->relname)));`
`1807`	`1809`	`for (count=0;count<rel->rd_att->natts;count++)`
`1808`	`1810`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit290713e

File tree

1 file changed

1 file changed

`‎src/backend/parser/parse_utilcmd.c`

0 commit comments