NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit2755abf

committed

Teach AbortOutOfAnyTransaction to clean up partially-started transactions.

AbortOutOfAnyTransaction failed to do anything if the state it saw onentry corresponded to failing partway through StartTransaction. I fixedAbortCurrentTransaction to cope with that case way back in commit60b2444, but evidently overlooked thatAbortOutOfAnyTransaction should do likewise.Back-patch to all supported branches. It's not clear that this omissionhas any more-than-cosmetic consequences, but it's also not clear that itdoesn't, so back-patching seems the least risky choice.

1 parentc89bdf7 commit2755abfCopy full SHA for 2755abf

File tree

1 file changed

+18

-1

lines changed

src/backend/access/transam
- xact.c

1 file changed

+18

-1

lines changed

`‎src/backend/access/transam/xact.c`

Lines changed: 18 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3861,7 +3861,24 @@ AbortOutOfAnyTransaction(void)`
`3861`	`3861`	`switch (s->blockState)`
`3862`	`3862`	`{`
`3863`	`3863`	`caseTBLOCK_DEFAULT:`
`3864`		`-/* Not in a transaction, do nothing */`
	`3864`	`+if (s->state==TRANS_DEFAULT)`
	`3865`	`+{`
	`3866`	`+/* Not in a transaction, do nothing */`
	`3867`	`+}`
	`3868`	`+else`
	`3869`	`+{`
	`3870`	`+/*`
	`3871`	`+ * We can get here after an error during transaction start`
	`3872`	`+ * (state will be TRANS_START). Need to clean up the`
	`3873`	`+ * incompletely started transaction. First, adjust the`
	`3874`	`+ * low-level state to suppress warning message from`
	`3875`	`+ * AbortTransaction.`
	`3876`	`+ */`
	`3877`	`+if (s->state==TRANS_START)`
	`3878`	`+s->state=TRANS_INPROGRESS;`
	`3879`	`+AbortTransaction();`
	`3880`	`+CleanupTransaction();`
	`3881`	`+}`
`3865`	`3882`	`break;`
`3866`	`3883`	`caseTBLOCK_STARTED:`
`3867`	`3884`	`caseTBLOCK_BEGIN:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2755abf

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xact.c`

0 commit comments