NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit2730eb9

committed

Change exec_eval_simple_expr's param list allocation call from

MemoryContextAllocZero back to MemoryContextAlloc, same as it was in 7.4.The zeroing is unnecessary since all the meaningful fields are filled injust below. I had made it do that out of neatnik-ism, but some testingwith an example provided by Pavel Stehule showed that the zeroing wasaccounting for about 5% of the runtime in a compute-intensive plpgsqlfunction. That seems a bit high of a price for neatnik-ism...

1 parent66d8165 commit2730eb9Copy full SHA for 2730eb9

File tree

1 file changed

-2

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

-2

lines changed

`‎src/pl/plpgsql/src/pl_exec.c‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* procedural language`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.126 2004/12/21 18:33:35 tgl Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.127 2005/01/13 23:07:34 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -3606,7 +3606,7 @@ exec_eval_simple_expr(PLpgSQL_execstate *estate,`
`3606`	`3606`	`* have more than one active param list.`
`3607`	`3607`	`*/`
`3608`	`3608`	`paramLI= (ParamListInfo)`
`3609`		`-MemoryContextAllocZero(econtext->ecxt_per_tuple_memory,`
	`3609`	`+MemoryContextAlloc(econtext->ecxt_per_tuple_memory,`
`3610`	`3610`	`(expr->nparams+1)*sizeof(ParamListInfoData));`
`3611`	`3611`
`3612`	`3612`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit2730eb9

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c‎`

0 commit comments