NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit26d905a

committed

Use SET TRANSACTION READ ONLY in pg_dump, if server supports it.

This currently does little except serve as documentation. (The one casewhere it has a performance benefit, SERIALIZABLE mode in 9.1 and up, wasalready using READ ONLY mode.) However, it's possible that it might haveperformance benefits in future, and in any case it seems like goodpractice since it would catch any accidentally non-read-only operations.Pavan Deolasee

1 parent4b94cfb commit26d905aCopy full SHA for 26d905a

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -618,7 +618,14 @@ main(int argc, char **argv)`
`618`	`618`	`else`
`619`	`619`	`ExecuteSqlStatement(fout,`
`620`	`620`	`"SET TRANSACTION ISOLATION LEVEL "`
`621`		`-"REPEATABLE READ");`
	`621`	`+"REPEATABLE READ, READ ONLY");`
	`622`	`+}`
	`623`	`+elseif (fout->remoteVersion >=70400)`
	`624`	`+{`
	`625`	`+/* note: comma was not accepted in SET TRANSACTION before 8.0 */`
	`626`	`+ExecuteSqlStatement(fout,`
	`627`	`+"SET TRANSACTION ISOLATION LEVEL "`
	`628`	`+"SERIALIZABLE READ ONLY");`
`622`	`629`	`}`
`623`	`630`	`else`
`624`	`631`	`ExecuteSqlStatement(fout,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit26d905a

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments