Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit26ce63c

Browse files
committed
Fix mdtruncate() to close fd.c handle of deleted segments.
mdtruncate() forgot to FileClose() a segment's mdfd_vfd, when deletingit. That lead to a fd.c handle to a truncated file being kept open untilbackend exit.The issue appears to have been introduced way back in1a5c450,before that the handle was closed inside FileUnlink().The impact of this bug is limited - only VACUUM and ON COMMIT TRUNCATEfor temporary tables, truncate files in place (i.e. TRUNCATE itself isnot affected), and the relation has to be bigger than 1GB. Theconsequences of a leaked fd.c handle aren't severe either.Discussion: <20160908220748.oqh37ukwqqncbl3n@alap3.anarazel.de>Backpatch: all supported releases
1 parent142a110 commit26ce63c

File tree

1 file changed

+1
-0
lines changed
  • src/backend/storage/smgr

1 file changed

+1
-0
lines changed

‎src/backend/storage/smgr/md.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -918,6 +918,7 @@ mdtruncate(SMgrRelation reln, ForkNumber forknum, BlockNumber nblocks)
918918
v=v->mdfd_chain;
919919
Assert(ov!=reln->md_fd[forknum]);/* we never drop the 1st
920920
* segment */
921+
FileClose(ov->mdfd_vfd);
921922
pfree(ov);
922923
}
923924
elseif (priorblocks+ ((BlockNumber)RELSEG_SIZE)>nblocks)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp