Commit262c1a4

committed

Unbreak comments on composite type attributes.

Report and diagnosis by Peter Eisentraut.

1 parent9df96f9 commit262c1a4Copy full SHA for 262c1a4

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -473,7 +473,7 @@ get_object_address_attribute(ObjectType objtype, List *objname,`
`473`	`473`	`/* Extract relation name and open relation. */`
`474`	`474`	`attname=strVal(lfirst(list_tail(objname)));`
`475`	`475`	`relname=list_truncate(list_copy(objname),list_length(objname)-1);`
`476`		`-relation=heap_openrv(makeRangeVarFromNameList(relname),lockmode);`
	`476`	`+relation=relation_openrv(makeRangeVarFromNameList(relname),lockmode);`
`477`	`477`	`reloid=RelationGetRelid(relation);`
`478`	`478`
`479`	`479`	`/* Look up attribute and construct return value. */`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -97,6 +97,10 @@ COMMENT ON TYPE bad IS 'bad comment';`
`97`	`97`	`ERROR: type "bad" does not exist`
`98`	`98`	`COMMENT ON TYPE default_test_row IS 'good comment';`
`99`	`99`	`COMMENT ON TYPE default_test_row IS NULL;`
	`100`	`+COMMENT ON COLUMN default_test_row.nope IS 'bad comment';`
	`101`	`+ERROR: column "nope" of relation "default_test_row" does not exist`
	`102`	`+COMMENT ON COLUMN default_test_row.f1 IS 'good comment';`
	`103`	`+COMMENT ON COLUMN default_test_row.f1 IS NULL;`
`100`	`104`	`-- Check shell type create for existing types`
`101`	`105`	`CREATE TYPE text_w_default;-- should fail`
`102`	`106`	`ERROR: type "text_w_default" already exists`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,9 @@ SELECT * FROM get_default_test();`
`95`	`95`	`COMMENT ON TYPE bad IS'bad comment';`
`96`	`96`	`COMMENT ON TYPE default_test_row IS'good comment';`
`97`	`97`	`COMMENT ON TYPE default_test_row ISNULL;`
	`98`	`+COMMENT ON COLUMN default_test_row.nope IS'bad comment';`
	`99`	`+COMMENT ON COLUMN default_test_row.f1 IS'good comment';`
	`100`	`+COMMENT ON COLUMN default_test_row.f1 ISNULL;`
`98`	`101`
`99`	`102`	`-- Check shell type create for existing types`
`100`	`103`	`CREATETYPEtext_w_default;-- should fail`

Comments

(0)