Commit25b7583

Neil Conway

committed

Minor perf tweak for _SPI_strdup(): if we're going to call strlen()

anyway, it is faster to memcpy() than to strcpy().

1 parent208d0a2 commit25b7583Copy full SHA for 25b7583

File tree

-3

lines changed

-3

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.64 2008/01/01 19:45:53 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/xml.c,v 1.65 2008/01/12 10:38:32 neilc Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -1821,9 +1821,10 @@ map_sql_value_to_xml_value(Datum value, Oid type)`
`1821`	`1821`	`staticchar*`
`1822`	`1822`	`_SPI_strdup(constchar*s)`
`1823`	`1823`	`{`
`1824`		`-char*ret=SPI_palloc(strlen(s)+1);`
	`1824`	`+size_tlen=strlen(s)+1;`
	`1825`	`+char*ret=SPI_palloc(len);`
`1825`	`1826`
`1826`		`-strcpy(ret,s);`
	`1827`	`+memcpy(ret,s,len);`
`1827`	`1828`	`returnret;`
`1828`	`1829`	`}`
`1829`	`1830`

Comments

(0)