Commit25371a7

committed

Remove pstrdup of TextDatumGetCString

The result of TextDatumGetCString is already palloc'ed.

1 parent0c22327 commit25371a7Copy full SHA for 25371a7

File tree

-4

lines changed

-4

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ GetSubscription(Oid subid, bool missing_ok)`
`75`	`75`	`Anum_pg_subscription_subconninfo,`
`76`	`76`	`&isnull);`
`77`	`77`	`Assert(!isnull);`
`78`		`-sub->conninfo=pstrdup(TextDatumGetCString(datum));`
	`78`	`+sub->conninfo=TextDatumGetCString(datum);`
`79`	`79`
`80`	`80`	`/* Get slotname */`
`81`	`81`	`datum=SysCacheGetAttr(SUBSCRIPTIONOID,`
`@@ -207,7 +207,7 @@ textarray_to_stringlist(ArrayType *textarray)`
`207`	`207`	`returnNIL;`
`208`	`208`
`209`	`209`	`for (i=0;i<nelems;i++)`
`210`		`-res=lappend(res,makeString(pstrdup(TextDatumGetCString(elems[i]))));`
	`210`	`+res=lappend(res,makeString(TextDatumGetCString(elems[i])));`
`211`	`211`
`212`	`212`	`returnres;`
`213`	`213`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -767,7 +767,7 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel)`
`767`	`767`	`datum=SysCacheGetAttr(SUBSCRIPTIONOID,tup,`
`768`	`768`	`Anum_pg_subscription_subconninfo,&isnull);`
`769`	`769`	`Assert(!isnull);`
`770`		`-conninfo=pstrdup(TextDatumGetCString(datum));`
	`770`	`+conninfo=TextDatumGetCString(datum);`
`771`	`771`
`772`	`772`	`/* Get slotname */`
`773`	`773`	`datum=SysCacheGetAttr(SUBSCRIPTIONOID,tup,`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -612,7 +612,7 @@ fetch_remote_table_info(char nspname, char relname,`
`612`	`612`	`while (tuplestore_gettupleslot(res->tuplestore, true, false,slot))`
`613`	`613`	`{`
`614`	`614`	`lrel->attnames[natt]=`
`615`		`-pstrdup(TextDatumGetCString(slot_getattr(slot,1,&isnull)));`
	`615`	`+TextDatumGetCString(slot_getattr(slot,1,&isnull));`
`616`	`616`	`Assert(!isnull);`
`617`	`617`	`lrel->atttyps[natt]=DatumGetObjectId(slot_getattr(slot,2,&isnull));`
`618`	`618`	`Assert(!isnull);`

Comments

(0)