NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit24688f4

committed

Fix minor thinko in convertToJsonb().

The amount of space to reserve for the value's varlena header isVARHDRSZ, not sizeof(VARHDRSZ). The latter coding accidentallyfailed to fail because of the way the VARHDRSZ macro is currentlydefined; but if we ever change it to return size_t (as one mightreasonably expect it to do), convertToJsonb() would have failed.Spotted by Mark Dilger.

1 parente39250c commit24688f4Copy full SHA for 24688f4

File tree

1 file changed

-1

lines changed

src/backend/utils/adt
- jsonb_util.c

1 file changed

-1

lines changed

`‎src/backend/utils/adt/jsonb_util.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1377,7 +1377,7 @@ convertToJsonb(JsonbValue *val)`
`1377`	`1377`	`initStringInfo(&buffer);`
`1378`	`1378`
`1379`	`1379`	`/* Make room for the varlena header */`
`1380`		`-reserveFromBuffer(&buffer,sizeof(VARHDRSZ));`
	`1380`	`+reserveFromBuffer(&buffer,VARHDRSZ);`
`1381`	`1381`
`1382`	`1382`	`convertJsonbValue(&buffer,&jentry,val,0);`
`1383`	`1383`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit24688f4

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/jsonb_util.c`

0 commit comments