NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit23fe7a7

committed

Un-break compression of plain-text output format in pg_dump.

pg_dump has historically understood -Z with no -F switch to mean thatit should emit a gzip-compressed version of its plain text output.This got broken through a misunderstanding in the 9.1 patch that addeddirectory output format. Restore the former behavior.Per complaint from Roger Niederland and diagnosis by Adrian Klaver.

1 parent84bbe57 commit23fe7a7Copy full SHA for 23fe7a7

File tree

1 file changed

-9

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-9

lines changed

`‎src/bin/pg_dump/pg_dump.c‎`

Lines changed: 3 additions & 9 deletions

Original file line number	Diff line number	Diff line change
`@@ -528,20 +528,14 @@ main(int argc, char **argv)`
`528`	`528`	`exit(1);`
`529`	`529`	`}`
`530`	`530`
	`531`	`+/* Identify archive format to emit */`
`531`	`532`	`archiveFormat=parseArchiveFormat(format,&archiveMode);`
`532`	`533`
`533`	`534`	`/* archiveFormat specific setup */`
`534`	`535`	`if (archiveFormat==archNull)`
`535`	`536`	`plainText=1;`
`536`	`537`
`537`		`-/*`
`538`		`- * Ignore compression level for plain format. XXX: This is a bit`
`539`		`- * inconsistent, tar-format throws an error instead.`
`540`		`- */`
`541`		`-if (archiveFormat==archNull)`
`542`		`-compressLevel=0;`
`543`		`-`
`544`		`-/* Custom and directory formats are compressed by default */`
	`538`	`+/* Custom and directory formats are compressed by default, others not */`
`545`	`539`	`if (compressLevel==-1)`
`546`	`540`	`{`
`547`	`541`	`if (archiveFormat==archCustom\|\|archiveFormat==archDirectory)`
`@@ -550,7 +544,7 @@ main(int argc, char **argv)`
`550`	`544`	`compressLevel=0;`
`551`	`545`	`}`
`552`	`546`
`553`		`-/open the output file /`
	`547`	`+/Open the output file /`
`554`	`548`	`g_fout=CreateArchive(filename,archiveFormat,compressLevel,archiveMode);`
`555`	`549`
`556`	`550`	`if (g_fout==NULL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit23fe7a7

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c‎`

0 commit comments