Commit23c356c

committed

Document and enforce that the usable range of setseed() arguments is

-1 to 1, not 0 to 1. The actual behavior for values within this rangedoes not change. Kris Jurka

1 parentbfce56e commit23c356cCopy full SHA for 23c356c

File tree

+12

-8

lines changed

+12

-8

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.423 2008/03/06 18:49:32 momjian Exp $ -->`
	`1`	`+<!-- $PostgreSQL: pgsql/doc/src/sgml/func.sgml,v 1.424 2008/03/10 12:39:22 tgl Exp $ -->`
`2`	`2`
`3`	`3`	`<chapter id="functions">`
`4`	`4`	`<title>Functions and Operators</title>`
`@@ -828,7 +828,7 @@`
`828`	`828`	`<row>`
`829`	`829`	`<entry><literal><function>setseed</function>(<type>dp</type>)</literal></entry>`
`830`	`830`	`<entry><type>void</type></entry>`
`831`		`- <entry>set seed for subsequent <literal>random()</literal> calls (value between 0 and 1.0)</entry>`
	`831`	`+ <entry>set seed for subsequent <literal>random()</literal> calls (value between-1.0 and 1.0)</entry>`
`832`	`832`	`<entry><literal>setseed(0.54823)</literal></entry>`
`833`	`833`	`<entry></entry>`
`834`	`834`	`</row>`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$PostgreSQL: pgsql/doc/src/sgml/ref/set.sgml,v 1.91 2007/09/11 00:06:41 tgl Exp $`
	`2`	`+$PostgreSQL: pgsql/doc/src/sgml/ref/set.sgml,v 1.92 2008/03/10 12:39:22 tgl Exp $`
`3`	`3`	`PostgreSQL documentation`
`4`	`4`	`-->`
`5`	`5`
`@@ -166,7 +166,7 @@ SET [ SESSION \| LOCAL ] TIME ZONE { <replaceable class="PARAMETER">timezone</rep`
`166`	`166`	`<para>`
`167`	`167`	`Sets the internal seed for the random number generator (the`
`168`	`168`	`function <function>random</function>). Allowed values are`
`169`		`- floating-point numbers between0 and 1, which are then`
	`169`	`+ floating-point numbers between-1 and 1, which are then`
`170`	`170`	`multiplied by 2<superscript>31</>-1.`
`171`	`171`	`</para>`
`172`	`172`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.153 2008/01/01 19:45:52 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/float.c,v 1.154 2008/03/10 12:39:22 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1684,8 +1684,12 @@ Datum`
`1684`	`1684`	`setseed(PG_FUNCTION_ARGS)`
`1685`	`1685`	`{`
`1686`	`1686`	`float8seed=PG_GETARG_FLOAT8(0);`
`1687`		`-intiseed= (int) (seed*MAX_RANDOM_VALUE);`
	`1687`	`+intiseed;`
`1688`	`1688`
	`1689`	`+if (seed<-1\|\|seed>1)`
	`1690`	`+elog(ERROR,"setseed parameter %f out of range [-1,1]",seed);`
	`1691`	`+`
	`1692`	`+iseed= (int) (seed*MAX_RANDOM_VALUE);`
`1689`	`1693`	`srandom((unsignedint)iseed);`
`1690`	`1694`
`1691`	`1695`	`PG_RETURN_VOID();`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`* Written by Peter Eisentraut <peter_e@gmx.net>.`
`11`	`11`	`*`
`12`	`12`	`* IDENTIFICATION`
`13`		`- * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.435 2008/03/1003:22:29 tgl Exp $`
	`13`	`+ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.436 2008/03/1012:39:23 tgl Exp $`
`14`	`14`	`*`
`15`	`15`	`*--------------------------------------------------------------------`
`16`	`16`	`*/`
`@@ -1849,7 +1849,7 @@ static struct config_real ConfigureNamesReal[] =`
`1849`	`1849`	`GUC_NO_SHOW_ALL \|GUC_NO_RESET_ALL \|GUC_NOT_IN_SAMPLE \|GUC_DISALLOW_IN_FILE`
`1850`	`1850`	`},`
`1851`	`1851`	`&phony_random_seed,`
`1852`		`-0.5,0.0,1.0,assign_random_seed,show_random_seed`
	`1852`	`+0.0,-1.0,1.0,assign_random_seed,show_random_seed`
`1853`	`1853`	`},`
`1854`	`1854`
`1855`	`1855`	`{`

Comments

(0)