NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit231f487

committed

Fix timeouts in PostgresNode::psql

Newer Perl or IPC::Run versions default to appending the filename to stringexceptions, e.g. the exception psql timed out is thrown as psql timed out at /usr/share/perl5/vendor_perl/IPC/Run.pm line 2961.To handle this, match exceptions with !~ rather than ne.From: Craig Ringer <craig@2ndquadrant.com>Reviewed-by: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

1 parent8f7277d commit231f487Copy full SHA for 231f487

File tree

1 file changed

-1

lines changed

src/test/perl
- PostgresNode.pm

1 file changed

-1

lines changed

`‎src/test/perl/PostgresNode.pm‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1139,7 +1139,7 @@ sub psql`
`1139`	`1139`	`# IPC::Run::run threw an exception. re-throw unless it's a`
`1140`	`1140`	`# timeout, which we'll handle by testing is_expired`
`1141`	`1141`	`die$exc_save`
`1142`		`-if (blessed($exc_save) \|\|$exc_savene$timeout_exception);`
	`1142`	`+if (blessed($exc_save) \|\|$exc_save!~/^\Q$timeout_exception\E/);`
`1143`	`1143`
`1144`	`1144`	`$ret =undef;`
`1145`	`1145`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit231f487

File tree

1 file changed

1 file changed

`‎src/test/perl/PostgresNode.pm‎`

0 commit comments