NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit21e3edd

committed

Revert the temporary patch to work around Snow Leopard readdir() bug.

Apple has fixed that bug in 10.6.2, and we should encourage users toupdate to that version rather than trusting this cosmetic patch.As was recently noted by Stephen Tyler, this patch was only maskingthe problem in the context of DROP TABLESPACE, but the failure couldoccur in other places such as pg_xlog cleanup.

1 parent089f4b9 commit21e3eddCopy full SHA for 21e3edd

File tree

1 file changed

-12

lines changed

src/backend/commands
- tablespace.c

1 file changed

-12

lines changed

`‎src/backend/commands/tablespace.c`

Lines changed: 1 addition & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.62 2009/09/12 15:51:52 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/commands/tablespace.c,v 1.63 2009/11/10 18:53:38 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -612,17 +612,6 @@ remove_tablespace_directories(Oid tablespaceoid, bool redo)`
`612`	`612`	`subfile)));`
`613`	`613`
`614`	`614`	`pfree(subfile);`
`615`		`-`
`616`		`-/*`
`617`		`- * OS X 10.6 and 10.6.1 have a bug in readdir() that causes the`
`618`		`- * next call to fail after deleting the current element. Hopefully`
`619`		`- * that will be fixed real soon, but for the moment we have this`
`620`		`- * ugly kluge to restart the directory scan.`
`621`		`- */`
`622`		`-#ifdef__darwin__`
`623`		`-FreeDir(dirdesc);`
`624`		`-dirdesc=AllocateDir(location);`
`625`		`-#endif`
`626`	`615`	`}`
`627`	`616`
`628`	`617`	`FreeDir(dirdesc);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit21e3edd

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablespace.c`

0 commit comments