NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit21b1634

committed

Fix heap_multi_insert to set t_self field in the caller's tuples.

If tuples were toasted, heap_multi_insert didn't update the ctid on theoriginal tuples. This caused a failure if there was an after trigger(including a foreign key), on the table, and a tuple got toasted.Per off-list report and test case from Ted Phelps

1 parentb4e3633 commit21b1634Copy full SHA for 21b1634

File tree

1 file changed

-0

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-0

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2291,6 +2291,14 @@ heap_multi_insert(Relation relation, HeapTuple *tuples, int ntuples,`
`2291`	`2291`	`CacheInvalidateHeapTuple(relation,heaptuples[i],NULL);`
`2292`	`2292`	`}`
`2293`	`2293`
	`2294`	`+/*`
	`2295`	`+ * Copy t_self fields back to the caller's original tuples. This does`
	`2296`	`+ * nothing for untoasted tuples (tuples[i] == heaptuples[i)], but it's`
	`2297`	`+ * probably faster to always copy than check.`
	`2298`	`+ */`
	`2299`	`+for (i=0;i<ntuples;i++)`
	`2300`	`+tuples[i]->t_self=heaptuples[i]->t_self;`
	`2301`	`+`
`2294`	`2302`	`pgstat_count_heap_insert(relation,ntuples);`
`2295`	`2303`	`}`
`2296`	`2304`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit21b1634

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments