Commit20a3830

committed

Add C comment explaining why we can't exclude checking functions in the

pg_catalog schema, even though they are not explicitly dumped (they areimplicitly dumped, e.g. create language plperl).

1 parentd4696fa commit20a3830Copy full SHA for 20a3830

File tree

-1

lines changed

-1

lines changed

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,12 @@ get_loadable_libraries(void)`
`142`	`142`	`DbInfo*active_db=&old_cluster.dbarr.dbs[dbnum];`
`143`	`143`	`PGconn*conn=connectToServer(&old_cluster,active_db->db_name);`
`144`	`144`
`145`		`-/* Fetch all libraries referenced in this DB */`
	`145`	`+/*`
	`146`	`+ *Fetch all libraries referenced in this DB. We can't exclude`
	`147`	`+ *the "pg_catalog" schema because, while such functions are not`
	`148`	`+ *explicitly dumped by pg_dump, they do reference implicit objects`
	`149`	`+ *that pg_dump does dump, e.g. creation of the plperl language.`
	`150`	`+ */`
`146`	`151`	`ress[dbnum]=executeQueryOrDie(conn,`
`147`	`152`	`"SELECT DISTINCT probin "`
`148`	`153`	`"FROMpg_catalog.pg_proc "`

Comments

(0)