NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit1f36fec

committed

Tweak distribute_qual_to_rels so that when we decide a pseudoconstant qual

can be pushed to the top of the join tree, we update both the relids andqualscope variables to keep them in sync. This prevents a possible laterfailure of an Assert clause, and affects nothing else since qualscope isn'tused later except for that Assert. At the moment the Assert shouldn't bereachable when we've pushed the qual up; but this is cheap insurance, andit's more sensible anyway in terms of the overall logic of the routine.Per analysis of a bug report from Stefan Huehner.I'm not back-patching this since it's just future-proofing; but if anyonegets tempted to change check_outerjoin_delay again in the back branches,this might be needed.

1 parent421c66b commit1f36fecCopy full SHA for 1f36fec

File tree

1 file changed

-1

lines changed

src/backend/optimizer/plan
- initsplan.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/plan/initsplan.c`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/optimizer/plan/initsplan.c,v 1.151 2009/04/19 19:46:33 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/optimizer/plan/initsplan.c,v 1.152 2009/05/06 20:31:18 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -818,9 +818,12 @@ distribute_qual_to_rels(PlannerInfo root, Node clause,`
`818`	`818`	`root->hasPseudoConstantQuals= true;`
`819`	`819`	`/* if not below outer join, push it to top of tree */`
`820`	`820`	`if (!below_outer_join)`
	`821`	`+{`
`821`	`822`	`relids=`
`822`	`823`	`get_relids_in_jointree((Node*)root->parse->jointree,`
`823`	`824`	`false);`
	`825`	`+qualscope=bms_copy(relids);`
	`826`	`+}`
`824`	`827`	`}`
`825`	`828`	`}`
`826`	`829`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1f36fec

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/initsplan.c`

0 commit comments