Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit1e0b436

Browse files
committed
Further code and wording tweaks in BRIN
Besides a couple of typo fixes, per David Rowley, Thom Brown, and AmitLangote, and mentions of BRIN in the general CREATE INDEX page again perDavid, this includes silencing MSVC compiler warnings (thanks Microsoft)and an additional variable initialization per Coverity scanner.
1 parent96a73fc commit1e0b436

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

‎doc/src/sgml/brin.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
<title>Built-in Operator Classes</title>
6565

6666
<para>
67-
The core <productname>PostgreSQL</productname> distribution includes
67+
The core <productname>PostgreSQL</productname> distribution
6868
includes the <acronym>BRIN</acronym> operator classes shown in
6969
<xref linkend="brin-builtin-opclasses-table">.
7070
</para>

‎doc/src/sgml/ref/create_index.sgml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ [ IF NOT EXISTS ] <replaceable class=
5757

5858
<para>
5959
<productname>PostgreSQL</productname> provides the index methods
60-
B-tree, hash, GiST, SP-GiST, andGIN. Users can also define their own index
61-
methods, but that is fairly complicated.
60+
B-tree, hash, GiST, SP-GiST,GIN,andBRIN. Users can also define their own
61+
indexmethods, but that is fairly complicated.
6262
</para>
6363

6464
<para>
@@ -166,7 +166,8 @@ CREATE [ UNIQUE ] INDEX [ CONCURRENTLY ] [ [ IF NOT EXISTS ] <replaceable class=
166166
<para>
167167
The name of the index method to be used. Choices are
168168
<literal>btree</literal>, <literal>hash</literal>,
169-
<literal>gist</literal>, <literal>spgist</> and <literal>gin</>.
169+
<literal>gist</literal>, <literal>spgist</>, <literal>gin</>, and
170+
<literal>brin</>.
170171
The default method is <literal>btree</literal>.
171172
</para>
172173
</listitem>
@@ -492,7 +493,7 @@ Indexes:
492493
</caution>
493494

494495
<para>
495-
Currently, only the B-tree, GiSTandGIN index methods support
496+
Currently, only the B-tree, GiST, GIN,andBRIN index methods support
496497
multicolumn indexes. Up to 32 fields can be specified by default.
497498
(This limit can be altered when building
498499
<productname>PostgreSQL</productname>.) Only B-tree currently

‎src/backend/access/brin/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ that page range is complete and new tuples belong in a new page range that
126126
hasn't yet been summarized. Those insertions do not create a new index
127127
entry; instead, the page range remains unsummarized until later.
128128

129-
Wehn VACUUM is run on the table, all unsummarized page ranges are
129+
Whenever VACUUM is run on the table, all unsummarized page ranges are
130130
summarized. This action can also be invoked by the user via
131131
brin_summarize_new_values(). Both these procedures scan all the
132132
unsummarized ranges, and create a summary tuple. Again, this includes the

‎src/backend/access/brin/brin.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,11 @@ brininsert(PG_FUNCTION_ARGS)
107107
BrinMemTuple*dtup;
108108
BlockNumberheapBlk;
109109
intkeyno;
110-
BrinTuple*tmptupPG_USED_FOR_ASSERTS_ONLY;
111-
BrinMemTuple*tmpdtupPG_USED_FOR_ASSERTS_ONLY;
112-
SizetmpsizPG_USED_FOR_ASSERTS_ONLY;
110+
#ifdefUSE_ASSERT_CHECKING
111+
BrinTuple*tmptup;
112+
BrinMemTuple*tmpdtup;
113+
Sizetmpsiz;
114+
#endif
113115

114116
CHECK_FOR_INTERRUPTS();
115117

‎src/backend/access/brin/brin_tuple.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ brin_form_tuple(BrinDesc *brdesc, BlockNumber blkno, BrinMemTuple *tuple,
9595
BrinTuple*rettuple;
9696
intkeyno;
9797
intidxattno;
98-
uint16phony_infomask;
98+
uint16phony_infomask=0;
9999
bits8*phony_nullbitmap;
100100
Sizelen,
101101
hoff,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp