Commit1d75101

committed

Add "skipping" to the NOTICE produced by DROP OPERATOR CLASS IF EXISTS.

This makes this message consistent with all the other similar noticesproduced by other DROP IF EXISTS commands.Noted by KaiGai Kohei

1 parent0bf0899 commit1d75101Copy full SHA for 1d75101

File tree

-2

lines changed

src
- backend/commands
  - opclasscmds.c
- test/regress/expected
  - drop_if_exists.out

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1564,7 +1564,7 @@ RemoveOpClass(RemoveOpClassStmt *stmt)`
`1564`	`1564`	`if (!HeapTupleIsValid(tuple))`
`1565`	`1565`	`{`
`1566`	`1566`	`ereport(NOTICE,`
`1567`		`-(errmsg("operator class \"%s\" does not exist for access method \"%s\"",`
	`1567`	`+(errmsg("operator class \"%s\" does not exist for access method \"%s\", skipping",`
`1568`	`1568`	`NameListToString(stmt->opclassname),stmt->amname)));`
`1569`	`1569`	`return;`
`1570`	`1570`	`}`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ NOTICE: server "test_server_exists" does not exist, skipping`
`205`	`205`	`DROP OPERATOR CLASS test_operator_class USING btree;`
`206`	`206`	`ERROR: operator class "test_operator_class" does not exist for access method "btree"`
`207`	`207`	`DROP OPERATOR CLASS IF EXISTS test_operator_class USING btree;`
`208`		`-NOTICE: operator class "test_operator_class" does not exist for access method "btree"`
	`208`	`+NOTICE: operator class "test_operator_class" does not exist for access method "btree", skipping`
`209`	`209`	`DROP OPERATOR CLASS test_operator_class USING no_such_am;`
`210`	`210`	`ERROR: access method "no_such_am" does not exist`
`211`	`211`	`DROP OPERATOR CLASS IF EXISTS test_operator_class USING no_such_am;`

Comments

(0)