Commit1d11885

committed

small fixes regarding the custom_private

1 parent4b216fd commit1d11885Copy full SHA for 1d11885

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ pack_runtimeappend_private(CustomScan cscan, RuntimeAppendPath path)`
`150`	`150`	`pfree(children[i]);`
`151`	`151`	`}`
`152`	`152`
`153`		`-/* Save main table and partition relids */`
	`153`	`+/* Save main table and partition relidsas first element of 'custom_private'*/`
`154`	`154`	`custom_private=lappend(custom_private,`
`155`	`155`	`list_make2(list_make1_oid(path->relid),`
`156`	`156`	`custom_oids));`
`@@ -197,9 +197,6 @@ unpack_runtimeappend_private(RuntimeAppendState scan_state, CustomScan cscan)`
`197`	`197`
`198`	`198`	`scan_state->children_table=children_table;`
`199`	`199`	`scan_state->relid=linitial_oid(linitial(runtimeappend_private));`
`200`		`-`
`201`		`-/* Delete items that belong to RuntimeAppend */`
`202`		`-cscan->custom_private=list_delete_first(cscan->custom_private);`
`203`	`200`	`}`
`204`	`201`
`205`	`202`	`Path*`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,7 @@ pack_runtimemergeappend_private(CustomScan cscan, MergeAppendGuts mag)`
`123`	`123`	`collations,`
`124`	`124`	`nullsFirst));`
`125`	`125`
	`126`	`+/* Append RuntimeMergeAppend's data to the 'custom_private' */`
`126`	`127`	`cscan->custom_private=lappend(cscan->custom_private,`
`127`	`128`	`runtimemergeappend_private);`
`128`	`129`	`}`
`@@ -149,7 +150,12 @@ unpack_runtimemergeappend_private(RuntimeMergeAppendState *scan_state,`
`149`	`150`	`*collations,`
`150`	`151`	`*nullsFirst;`
`151`	`152`
`152`		`-runtimemergeappend_private=linitial(cscan->custom_private);`
	`153`	`+/*`
	`154`	`+ * RuntimeMergeAppend node's private data is stored in`
	`155`	`+ * second element of the 'custom_private' list, right after`
	`156`	`+ * the RuntimeAppend node's private data`
	`157`	`+ */`
	`158`	`+runtimemergeappend_private=lsecond(cscan->custom_private);`
`153`	`159`	`scan_state->numCols=intVal(linitial(runtimemergeappend_private));`
`154`	`160`
`155`	`161`	`sortColIdx=linitial(lsecond(runtimemergeappend_private));`

Comments

(0)