NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit1b1b0ac

committed

Fix oversight in ALTER TABLE ENABLE/DISABLE RULE patch: the new enabled

field needs to be included in equalRuleLocks() comparisons, else updateswill fail to propagate into relcache entries when they have positivereference count (ie someone is using the relcache entry).Per report from Alex Hunsaker.

1 parent2c38b8c commit1b1b0acCopy full SHA for 1b1b0ac

File tree

1 file changed

-1

lines changed

src/backend/utils/cache
- relcache.c

1 file changed

-1

lines changed

`‎src/backend/utils/cache/relcache.c`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.278 2008/12/03 13:05:22 heikki Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.279 2008/12/30 03:59:19 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -777,6 +777,8 @@ equalRuleLocks(RuleLock rlock1, RuleLock rlock2)`
`777`	`777`	`return false;`
`778`	`778`	`if (rule1->attrno!=rule2->attrno)`
`779`	`779`	`return false;`
	`780`	`+if (rule1->enabled!=rule2->enabled)`
	`781`	`+return false;`
`780`	`782`	`if (rule1->isInstead!=rule2->isInstead)`
`781`	`783`	`return false;`
`782`	`784`	`if (!equal(rule1->qual,rule2->qual))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1b1b0ac

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/relcache.c`

0 commit comments