NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit1ae2feb

Michael Paquier

committed

Fix inconsistency in call of readlink()

If the target path is too long, an error needs to be emitted as well.The buffer is correctly null-terminated, this will just avoid runninginto weird problems should the target have a too long name.

1 parentb84334b commit1ae2febCopy full SHA for 1ae2feb

File tree

1 file changed

-3

lines changed

dir.c

1 file changed

-3

lines changed

`‎dir.c`

Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -292,11 +292,13 @@ dir_list_file_internal(parray files, const char root, const char *exclude[],`
`292`	`292`	`charlinked[MAXPGPATH];`
`293`	`293`
`294`	`294`	`len=readlink(file->path,linked,sizeof(linked));`
`295`		`-if (len==-1)`
`296`		`-{`
	`295`	`+if (len<0)`
`297`	`296`	`elog(ERROR,"cannot read link \"%s\": %s",file->path,`
`298`	`297`	`strerror(errno));`
`299`		`-}`
	`298`	`+if (len >=sizeof(linked))`
	`299`	`+elog(ERROR,"symbolic link \"%s\" target is too long\n",`
	`300`	`+file->path);`
	`301`	`+`
`300`	`302`	`linked[len]='\0';`
`301`	`303`	`file->linked=pgut_strdup(linked);`
`302`	`304`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1ae2feb

File tree

1 file changed

1 file changed

`‎dir.c`

0 commit comments