Commit18e752f

committed

If pk is NULL, the backend would segfault when accessing ->algo and the

following NULL check was never reached.This problem was found by Coccinelle (null_ref.cocci from coccicheck).Marti Raudsepp

1 parentdef30e8 commit18e752fCopy full SHA for 18e752f

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -199,14 +199,16 @@ pgp_write_pubenc_sesskey(PGP_Context ctx, PushFilter dst)`
`199`	`199`	`PGP_PubKey*pk=ctx->pub_key;`
`200`	`200`	`uint8ver=3;`
`201`	`201`	`PushFilter*pkt=NULL;`
`202`		`-uint8algo=pk->algo;`
	`202`	`+uint8algo;`
`203`	`203`
`204`	`204`	`if (pk==NULL)`
`205`	`205`	`{`
`206`	`206`	`px_debug("no pubkey?\n");`
`207`	`207`	`returnPXE_BUG;`
`208`	`208`	`}`
`209`	`209`
	`210`	`+algo=pk->algo;`
	`211`	`+`
`210`	`212`	`/*`
`211`	`213`	`* now write packet`
`212`	`214`	`*/`

Comments

(0)