NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commit1886752

committed

Add missing CHECK_FOR_INTERRUPTS in lseg_inside_poly

Apparently, there are bugs in this code that cause it to loop endlessly.That bug still needs more research, but in the meantime it's clear thatthe loop is missing a check for interrupts so that it can be cancelledtimely.Backpatch to 9.1 -- this has been missing since49475aa.

1 parentc6eced0 commit1886752Copy full SHA for 1886752

File tree

1 file changed

-0

lines changed

src/backend/utils/adt
- geo_ops.c

1 file changed

-0

lines changed

`‎src/backend/utils/adt/geo_ops.c‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@`
`20`	`20`	`#include<ctype.h>`
`21`	`21`
`22`	`22`	`#include"libpq/pqformat.h"`
	`23`	`+#include"miscadmin.h"`
`23`	`24`	`#include"utils/builtins.h"`
`24`	`25`	`#include"utils/geo_decls.h"`
`25`	`26`
`@@ -3931,6 +3932,8 @@ lseg_inside_poly(Point a, Point b, POLYGON *poly, int start)`
`3931`	`3932`	`{`
`3932`	`3933`	`Point*interpt;`
`3933`	`3934`
	`3935`	`+CHECK_FOR_INTERRUPTS();`
	`3936`	`+`
`3934`	`3937`	`s.p[1]=poly->p[i];`
`3935`	`3938`
`3936`	`3939`	`if (on_ps_internal(t.p,&s))`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit1886752

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/geo_ops.c‎`

0 commit comments