NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commit17c03b3

committed

Revert treatment of NOTIFY in rules to its pre-7.1 behavior: notify will

occur unconditionally, even if the rule should otherwise executeconditionally. This is more useful than giving an error, even though it'snot truly the correct behavior. Per today's pghackers discussion.

1 parent8c55728 commit17c03b3Copy full SHA for 17c03b3

File tree

2 files changed

+30

-12

lines changed

doc/src/sgml/ref
- create_rule.sgml
src/backend/rewrite
- rewriteManip.c

2 files changed

+30

-12

lines changed

`‎doc/src/sgml/ref/create_rule.sgml`

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`<!--`
`2`		`-$Header: /cvsroot/pgsql/doc/src/sgml/ref/create_rule.sgml,v 1.25 2001/09/03 12:57:49 petere Exp $`
	`2`	`+$Header: /cvsroot/pgsql/doc/src/sgml/ref/create_rule.sgml,v 1.26 2001/09/07 20:52:30 tgl Exp $`
`3`	`3`	`Postgres documentation`
`4`	`4`	`-->`
`5`	`5`
`@@ -249,6 +249,20 @@ SELECT * FROM emp;`
`249`	`249`	`</programlisting></para>`
`250`	`250`	`</example>`
`251`	`251`	`</para>`
	`252`	`+`
	`253`	`+ <para>`
	`254`	`+ Presently, if a rule contains a NOTIFY query, the NOTIFY will be executed`
	`255`	`+ unconditionally --- that is, the NOTIFY will be issued even if there are`
	`256`	`+ not any rows that the rule should apply to. For example, in`
	`257`	`+ <programlisting>`
	`258`	`+CREATE RULE notify_me AS ON UPDATE TO mytable DO NOTIFY mytable;`
	`259`	`+`
	`260`	`+UPDATE mytable SET name = 'foo' WHERE id = 42;`
	`261`	`+ </programlisting>`
	`262`	`+ one NOTIFY event will be sent during the UPDATE, whether or not there`
	`263`	`+ are any rows with id = 42. This is an implementation restriction that`
	`264`	`+ may be fixed in future releases.`
	`265`	`+ </para>`
`252`	`266`	`</refsect2>`
`253`	`267`	`</refsect1>`
`254`	`268`

`‎src/backend/rewrite/rewriteManip.c`

Lines changed: 15 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteManip.c,v 1.57 2001/04/18 20:42:55 tgl Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/rewrite/rewriteManip.c,v 1.58 2001/09/07 20:52:31 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -592,15 +592,21 @@ AddQual(Query parsetree, Node qual)`
`592`	`592`
`593`	`593`	`if (parsetree->commandType==CMD_UTILITY)`
`594`	`594`	`{`
`595`		`-`
`596`	`595`	`/*`
`597`		`- * Noplace to put the qual on a utility statement.`
	`596`	`+ * There's noplace to put the qual on a utility statement.`
	`597`	`+ *`
	`598`	`+ * If it's a NOTIFY, silently ignore the qual; this means that the`
	`599`	`+ * NOTIFY will execute, whether or not there are any qualifying rows.`
	`600`	`+ * While clearly wrong, this is much more useful than refusing to`
	`601`	`+ * execute the rule at all, and extra NOTIFY events are harmless for`
	`602`	`+ * typical uses of NOTIFY.`
`598`	`603`	`*`
`599`		`- * For now, we expect utility stmt to be a NOTIFY, so give a specific`
`600`		`- * error message for that case.`
	`604`	`+ * If it isn't a NOTIFY, error out, since unconditional execution`
	`605`	`+ * of other utility stmts is unlikely to be wanted. (This case is`
	`606`	`+ * not currently allowed anyway, but keep the test for safety.)`
`601`	`607`	`*/`
`602`	`608`	`if (parsetree->utilityStmt&&IsA(parsetree->utilityStmt,NotifyStmt))`
`603`		`-elog(ERROR,"Conditional NOTIFY is not implemented");`
	`609`	`+return;`
`604`	`610`	`else`
`605`	`611`	`elog(ERROR,"Conditional utility statements are not implemented");`
`606`	`612`	`}`
`@@ -634,15 +640,13 @@ AddHavingQual(Query parsetree, Node havingQual)`
`634`	`640`
`635`	`641`	`if (parsetree->commandType==CMD_UTILITY)`
`636`	`642`	`{`
`637`		`-`
`638`	`643`	`/*`
`639`		`- *Noplace to put the qual on a utility statement.`
	`644`	`+ *There's noplace to put the qual on a utility statement.`
`640`	`645`	`*`
`641`		`- * For now, we expect utility stmt to be a NOTIFY, so give a specific`
`642`		`- * error message for that case.`
	`646`	`+ * See comments in AddQual for motivation.`
`643`	`647`	`*/`
`644`	`648`	`if (parsetree->utilityStmt&&IsA(parsetree->utilityStmt,NotifyStmt))`
`645`		`-elog(ERROR,"Conditional NOTIFY is not implemented");`
	`649`	`+return;`
`646`	`650`	`else`
`647`	`651`	`elog(ERROR,"Conditional utility statements are not implemented");`
`648`	`652`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit17c03b3

File tree

2 files changed

2 files changed

`‎doc/src/sgml/ref/create_rule.sgml`

`‎src/backend/rewrite/rewriteManip.c`

0 commit comments