Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit177c56d

Browse files
committed
postgres_fdw: Rephrase comment.
Per gripe from Thomas Munro, who only complained about a morelocalized problem, but I couldn't resist a bit more wordsmithing.
1 parent9c188a8 commit177c56d

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

‎contrib/postgres_fdw/postgres_fdw.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4264,16 +4264,15 @@ postgresGetForeignJoinPaths(PlannerInfo *root,
42644264
fpinfo->attrs_used=NULL;
42654265

42664266
/*
4267-
* In case there is a possibility that EvalPlanQual will be executed, we
4268-
* should be able to reconstruct the row, from base relations applying all
4269-
* the conditions. We create a local plan from a suitable local path
4270-
* available in the path list. In case such a path doesn't exist, we can
4271-
* not push the join to the foreign server since we won't be able to
4267+
* If there is a possibility that EvalPlanQual will be executed, we need
4268+
* to be able to reconstruct the row using scans of the base relations.
4269+
* GetExistingLocalJoinPath will find a suitable path for this purpose in
4270+
* the path list of the joinrel, if one exists. We must be careful to
4271+
* call it before adding any ForeignPath, since the ForeignPath might
4272+
* dominate the only suitable local path available. We also do it before
42724273
* reconstruct the row for EvalPlanQual(). Find an alternative local path
4273-
* before we add ForeignPath, lest the new path would kick possibly the
4274-
* only local path. Do this before calling foreign_join_ok(), since that
4275-
* function updates fpinfo and marks it as pushable if the join is found
4276-
* to be pushable.
4274+
* calling foreign_join_ok(), since that function updates fpinfo and marks
4275+
* it as pushable if the join is found to be pushable.
42774276
*/
42784277
if (root->parse->commandType==CMD_DELETE||
42794278
root->parse->commandType==CMD_UPDATE||

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp