Commit1743778

committed

If RelationBuildDesc() fails to open a critical system index, PANIC with

a relevant error message instead of just dumping core. Odd that nobodyreported this before Darren Reed.

1 parent00941ee commit1743778Copy full SHA for 1743778

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.266 2008/01/01 19:45:53 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.267 2008/02/27 17:44:19 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -2550,7 +2550,10 @@ RelationCacheInitializePhase2(void)`
`2550`	`2550`
`2551`	`2551`	`#defineLOAD_CRIT_INDEX(indexoid) \`
`2552`	`2552`	`do { \`
`2553`		`-ird = RelationBuildDesc((indexoid), NULL); \`
	`2553`	`+ird = RelationBuildDesc(indexoid, NULL); \`
	`2554`	`+if (ird == NULL) \`
	`2555`	`+elog(PANIC, "could not open critical system index %u", \`
	`2556`	`+ indexoid); \`
`2554`	`2557`	`ird->rd_isnailed = true; \`
`2555`	`2558`	`ird->rd_refcnt = 1; \`
`2556`	`2559`	`} while (0)`

Comments

(0)